chirpstack-application-server icon indicating copy to clipboard operation
chirpstack-application-server copied to clipboard

[subtle bug] don't delete ping (discovery) lookups from Redis

Open RodionGork opened this issue 3 years ago • 0 comments

There is sublte issue with gateway discovery pings processing. When gateway sends responses for the ping, response includes the "self-ping". It is skipped later, however if response comes in more than single packet, then such "self-ping" causes deletion of ping lookup record from Redis.

Next moment another response may come with "peer-ping" response, but it only founds that lookup can't find ping data anymore and drops queer error:

 ping lookup error: redis: nil

My understanding is that it would be ok not to remove ping lookup records manually, they are anyway set to expire in 10 seconds. Hence it should be ok to remove these two fragments.

RodionGork avatar Jun 15 '22 14:06 RodionGork