brigade icon indicating copy to clipboard operation
brigade copied to clipboard

Fix broken image links

Open elishagreenwald opened this issue 3 years ago • 8 comments

@brian-shourd-tpt and I noticed the path seems to be incorrect for image links causing images not to render here As an example, this does load with the v1 prefix.

What this PR does / why we need it: This PR attempts to fix image links in the docs.

Special notes for your reviewer: n/a

If applicable:

[n/a] this PR contains documentation [n/a] this PR contains unit tests [n/a] this PR has been tested for backwards compatibility

elishagreenwald avatar Jul 19 '22 20:07 elishagreenwald

Deploy Preview for brigade-v1-docs ready!

Name Link
Latest commit 401dba898f801b85ad7094f6c5165607a1de0271
Latest deploy log https://app.netlify.com/sites/brigade-v1-docs/deploys/62d83ab5484fba0008aa13b7
Deploy Preview https://deploy-preview-1981--brigade-v1-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Jul 19 '22 20:07 netlify[bot]

Deploy Preview for brigade-docs ready!

Name Link
Latest commit 401dba898f801b85ad7094f6c5165607a1de0271
Latest deploy log https://app.netlify.com/sites/brigade-docs/deploys/62d83ab50ddd280008994f06
Deploy Preview https://deploy-preview-1981--brigade-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Jul 19 '22 20:07 netlify[bot]

The image URLs should be relative so this doesn't happen again.

krancour avatar Jul 20 '22 16:07 krancour

@krancour does this look ok now or should I do s/t else?

elishagreenwald avatar Jul 26 '22 15:07 elishagreenwald

@elishagreenwald looks fine to me, but I cannot review and merge anymore.

krancour avatar Jul 26 '22 18:07 krancour

@elishagreenwald looks fine to me, but I cannot review and merge anymore.

hm, is that based on the way I opened this PR or is there someone else who can? should I open a new PR a different way? Thanks in advance!

elishagreenwald avatar Jul 27 '22 13:07 elishagreenwald

@elishagreenwald you did everything right. I stepped down as maintainer. So I'm helping out with reviews where I can, but I don't have authority to approve or merge.

krancour avatar Jul 27 '22 14:07 krancour

@elishagreenwald you did everything right. I stepped down as maintainer. So I'm helping out with reviews where I can, but I don't have authority to approve or merge.

so how do i add a reviewer? @jorgearteiro are you able to approve?

elishagreenwald avatar Aug 24 '22 02:08 elishagreenwald