BricksLLM icon indicating copy to clipboard operation
BricksLLM copied to clipboard

both proxy and admin log do not need pass in correlation id explicitly

Open GingerMoon opened this issue 1 year ago • 1 comments

Hi @spikelu2016 , this PR changes all the correlation id log related code, both admin and proxy. Now the sub logger with correlation id is stored inside the http request context. Whenever we can get it from the http request context whenever we need it, especially when we are in some deeper place. In such cases, we need to pass the http request context as the parameter to this "deeper place".

Please feel free to let me know if you have any comments.

GingerMoon avatar May 20 '24 02:05 GingerMoon

unused cid can still be found across many functions. you can find all of them using vscode search. removing all of them would be great

spikelu2016 avatar May 20 '24 23:05 spikelu2016

all cids are removed. the commit is squashed.

GingerMoon avatar May 21 '24 00:05 GingerMoon