date-time icon indicating copy to clipboard operation
date-time copied to clipboard
verified publisher icon brick

Implement contains, intersection and `of` methods for Interval

Open someniatko opened this issue 3 years ago • 1 comments

closes #63

someniatko avatar Aug 12 '22 08:08 someniatko

Do you think it makes sense to also implement isEqualTo() and toNativeDatePeriod()?

someniatko avatar Aug 12 '22 12:08 someniatko

@BenMorel ping 🤸

someniatko avatar May 15 '23 07:05 someniatko

Do you think it makes sense to also implement isEqualTo() and toNativeDatePeriod()?

  • isEqualTo(): yes, and you may use it in your tests as per my comment
  • toNativeDatePeriod(): it looks like DatePeriod is about recurring periods, so I don't think they represent the same concept. I'd pass on this one.

BenMorel avatar May 17 '23 21:05 BenMorel

Okay, I will implement isEqualTo() as well.

someniatko avatar May 18 '23 07:05 someniatko

Done! Code coverage has been decreased for the classes this PR is not responsible for, maybe something has changed in the method of the coverage calculation.

someniatko avatar May 18 '23 08:05 someniatko

Thank you! Released as 0.4.2 :tada:

BenMorel avatar May 19 '23 21:05 BenMorel