Brian L. McMichael

Results 35 comments of Brian L. McMichael

Check out https://github.com/makerdao/ilk-registry/pull/1/files

I figured in the case where we modified the core contracts we would probably want to re-deploy the registry entirely. I'm actually not convinced that the `file` operations are better...

I think the idea here was that governance could use this to remove an adapter and then atomically add the new one. That would effectively overwrite the old one. This...

Yeah, something like that. I don't really know how we'd get into that situation, ideally we'd `cage` the old adapter and that would make it eligible for removal via the...

This one is turning out to be a little sticky. Using the example: `(ノ°Д°)ノ︵ ┻━┻` is actually causing problems on the Rails end. On the system, `)` is actually a...

The problem seems to be coming from the OodAppkit files api generator. There may be a setting required for `Addressible` gem to handle this appropriately. ``` irb(main):002:0> p = Pathname.new...

Appears to affect Addressible 2.5.1 ``` Addressable::URI.parse('http://www.google.com/(╯°□°)╯︵ ┻━┻').normalize => # ```

The problem with Addressable seems intentional. > It's doing the right thing actually. IRIs (unicode-friendly URIs) use unicode normalization form KC to limit phishing. NFKC tends to do perceptual codepoint...

12px is a pretty standard font size for editors and word processors, which is why I went with that. There should also be a cookie that stores your preference and...

I wonder if the cookies are expiring. Maybe we could switch the memory of your settings over to localStorage so it persists longer.