Requestrr - Change to tar.gz instead of zip
Hello,
I currently maintain Requestrr, a user reached out today and was using one of your old scripts to setup Requestrr. I noticed when looking over the script it is downloading and extracting the zip files form GitHub, I am going to stop uploading those version going forward and only providing tar.gz files.
Just wanted to reach out and make the suggestion to update your script. These are the lines I picked up to help :)
https://github.com/brettpetch/hosted-scripts/blob/68d18a3bc418a94f6acbd79ff8a2943a55fcbe44/requestrr.sh#L37
dlurl="https://github.com/thomst08/requestrr/releases/download/${version}/requestrr-linux-${arch}.tar.gz"
https://github.com/brettpetch/hosted-scripts/blob/68d18a3bc418a94f6acbd79ff8a2943a55fcbe44/requestrr.sh#L40
if ! curl "$dlurl" -L -o $HOME/.tmp/requestrr.tar.gz >> "$log" 2>&1; then
https://github.com/brettpetch/hosted-scripts/blob/68d18a3bc418a94f6acbd79ff8a2943a55fcbe44/requestrr.sh#L224-L225
tar -xzf "$HOME/.tmp/requestrr.tar.gz" -C $HOME/ >> ${log} 2>&1
rm -rf "$HOME/.tmp/requestrr.tar.gz"
I also noticed a bug with your script, in the code you are configuring the appSettings.json file.
This is used to control where the config path is in the latest version ,because of the change it breaks the latest version and doesn't start.
https://github.com/brettpetch/hosted-scripts/blob/68d18a3bc418a94f6acbd79ff8a2943a55fcbe44/requestrr.sh#L209-L217
This is the correct file
{
"Logging": {
"LogLevel": {
"Default": "Warning"
}
},
"AllowedHosts": "*",
"ConfigFolder": "./config"
}
Thanks. I’ll get a pr together this weekend.