Bram Evert
Bram Evert
Ah scratch that theory then
Just wanted to check on the status of this - it's important for pulse plotting to work.
I'm a little surprised by the extent of the changes in this PR. I was expecting something more along the lines of this: ```python from quil.program import Program from typing...
Yup, that's true. I don't have any need for those things for my use case. On Fri, Oct 11, 2024, 20:00 Kalan ***@***.***> wrote: > I'm a little surprised by...
We'd like the behaviour to be as follows: If a DEFCAL is found for the instruction, then it should be expanded. If no DEFCAL is found, but a DEFCIRCUIT is,...
`FSIM` is included in pyquil (see https://github.com/rigetti/pyquil/blob/master/pyquil/simulation/matrices.py#L233 and https://github.com/rigetti/pyquil/blob/master/pyquil/gates.py#L551). I believe we should have a single source of truth for the default gate set. Most sensible this would live in...
`pyquil.gates` has an FSIM gate as well. If quil-rs is going to provide the unitary associated with gate, it needs to be aware of the standard definitions. Alternatively, we could...
The translator requires only a DEFCAL, I think. It's not in the qvm, quilc, or the quil-spec, but I'm happy to make the MR there if it helps.
Yes, the pyquil state-vector machinery, which is where `lifted_gate` comes from, assumes qubits indexed from 0 to n. I'm not sure this is a bug, I think it was made...
My point was a little more subtle though. If you have a program ``` CCNOT 20 15 10 CCNOT 15 10 20 ``` and you used this method, both gates...