braintree_java icon indicating copy to clipboard operation
braintree_java copied to clipboard

equals() and hashCode() methods are missing in classed provided by SDK

Open kmichalak opened this issue 7 years ago • 2 comments

General information

  • SDK/Library version: 2.27.2 and any previous version
  • Environment: N/A
  • Language, language version, and OS: Any version of Java and any OS

Issue description

Looks like equals() and hashCode() methods are not available for classes provided by SDK. It makes integration and unit testing much harder, as custom assertions/matchers are needed to check for example if com.braintreegateway.Trasanction instance contains all necessary data. Currenlty to assert an object state I have to implement customer Hamcrest matcher, create long list of assertions (what is not the best idea from test design or good practices perspective) or use additional tools to perform reflection based comparison. Adding implementation for equals() and hashCode() methods will simplify testing process.

kmichalak avatar Apr 11 '18 08:04 kmichalak

I agree that it would be nice to have these methods implemented.

We'll keep this in mind as we try out lombok (mentioned in #57) which looks like it is able to generate equals and hashCode methods.

quinnjn avatar Apr 18 '18 16:04 quinnjn

for internal notekeeping, ticket 630

hollabaq86 avatar May 02 '22 21:05 hollabaq86