braintree_java icon indicating copy to clipboard operation
braintree_java copied to clipboard

Extract HTTP client logic to HttpClient and JavaHttpClient. Make Http…

Open githubmicrob opened this issue 1 year ago • 1 comments

…Client configurable.

Summary

Extracted HTTP client functionality to separate class. Introduced HttpClient interface to make the implementation of HTTP client replaceable. In our case having another implementation is necessary because Java implementation doesn't work with HTTPS proxies.

Fix: braintree/braintree_java#135

Checklist

  • [x] Added changelog entry
  • [x] Ran unit tests (rake test:unit)
  • [x] I understand that unless this is a Draft PR or has a DO NOT MERGE label, this PR is considered to be in a deploy ready state and can be deployed if merged to main

githubmicrob avatar Nov 15 '24 16:11 githubmicrob

Hello @saralvasquez, Hope you can advice what should be the process of this PR🙏. Seems it will allow to use Braintree java sdk behind https proxy

ishestakov avatar Mar 12 '25 21:03 ishestakov