react-carousel icon indicating copy to clipboard operation
react-carousel copied to clipboard

Last slide is aligned to the left but should be aligned to the right / Track width

Open Romcol opened this issue 5 years ago • 14 comments

Issuehunt badges

Hi,

Having multiple items per page on the carousel we would expect the "next arrow" not to be clickable when the last item is shown. Currently, the arrow is clickable and also the carousel is draggable to the right as long as the last item is not aligned to the left. I think, as seen with other libs, we shouldn't be able to slide that far down the track.

To reproduce :

Remove infinite on this example : https://brainhubeu.github.io/react-carousel/docs/examples/multipleItems .

https://i.ibb.co/WnZ98Gy/Capture-d-cran-du-2020-05-25-15-57-12.png

https://i.ibb.co/W6Bh85v/Capture-d-cran-du-2020-05-25-15-56-09.png

Thank you for the lib :fire:


IssueHunt Summary

Backers (Total: $0.00)

Submitted pull Requests


Become a backer now!

Or submit a pull request to get the deposits!

Tips

Romcol avatar May 25 '20 14:05 Romcol

@Romcol

Thanks for reporting this.

I also noticed that, I don't like this behavior but for me, it's a minor bug.

You're more than welcome to open a PR to fix that.

You can also invite your colleagues to like (👍) this issue so more 👍it has, it's more likely to be fixed by us.

piotr-s-brainhub avatar May 25 '20 14:05 piotr-s-brainhub

Hi,

@piotr-s-brainhub Sure, I'll try to make a PR. Have you got any pointers on how to implement this?

I've seen that there's something such as an activeSlide which is aligned to the left. We can prevent the user from selecting a slide past a certain slide maybe?

Romcol avatar Jun 03 '20 12:06 Romcol

@Romcol

I'm not sure about an exact place in the code but generally, I guess, we should calculate whether there's a next slide to display and according to that allow or not to move right.

piotr-s-brainhub avatar Jun 04 '20 01:06 piotr-s-brainhub

@piotr-s-brainhub has funded $7.00 to this issue.


issuehunt-oss[bot] avatar Jul 14 '20 23:07 issuehunt-oss[bot]

I can reproduce it on 1.19.17. Is it released?

meysamizadmehr avatar Jul 15 '20 15:07 meysamizadmehr

@meysamizadmehr

not yet, if it was fixed, the GitHub issue would be closed

piotr-s-brainhub avatar Jul 15 '20 15:07 piotr-s-brainhub

@Romcol

I leave the brainhubeu organization so I must remove the IssueHunt funding as it's only me who's able to manage these funds.

Moreover, the team decided on Thursday about stopping using IssueHunt.

piotr-s-brainhub avatar Jul 18 '20 20:07 piotr-s-brainhub

@piotr-s-brainhub has cancelled funding for this issue.(Cancelled amount: $7.00) See it on IssueHunt

issuehunt-oss[bot] avatar Jul 18 '20 20:07 issuehunt-oss[bot]

@Romcol

As your work is already on https://github.com/brainhubeu/react-carousel/pull/537, you can try reaching out @RobertHebel , @humbak or @Lukasz-pluszczewski or another brainhubeu organization member in order to be rewarded on IssueHunt.

piotr-s-brainhub avatar Jul 18 '20 21:07 piotr-s-brainhub

Hi,

Cool. How should I reach you? Thanks

Romcol avatar Jul 21 '20 08:07 Romcol

@Romcol We are working on restoring funding for already opened PRs. On the next Thursday, I will be able to re-assign money for this issue. Is it ok for you to wait for the funding one week?

RobertHebel avatar Jul 23 '20 09:07 RobertHebel

Issuehunt for this issue will be restored tomorrow

RobertHebel avatar Jul 30 '20 13:07 RobertHebel

@roberthebel has funded $7.00 to this issue.


issuehunt-oss[bot] avatar Jul 31 '20 11:07 issuehunt-oss[bot]

@roberthebel has cancelled funding for this issue.(Cancelled amount: $7.00) See it on IssueHunt

issuehunt-oss[bot] avatar Jul 01 '22 11:07 issuehunt-oss[bot]