braid-spec icon indicating copy to clipboard operation
braid-spec copied to clipboard

Get requests with 'version' header should all appear in same section.

Open blottn opened this issue 4 years ago • 2 comments

The heading "If a GET request contains a Version header" implies that all further headings would have no version header.

blottn avatar Aug 07 '21 11:08 blottn

Hi, I'm not sure what you mean. Can you be more explicit? By "Section", do you mean "Section 2.4"? Or are you just referring to the 10 lines from 375-385, or some other range of lines? Which requests do you think should appear in the section?

toomim avatar Aug 07 '21 22:08 toomim

Hey, sorry for the poor explanation! I meant, within section 2.4, there are 2 headings, one regarding requests with Version headers and one regarding requests with Parents headers. The former implies that latter headings do not contain any requests with Version headers. However the point regarding requests with both parents and versions appears in the second.

Im suggesting that maybe this needs to be moved into the first heading or create a third heading "If a GET request contains both a Parents and a Version header"

blottn avatar Aug 08 '21 09:08 blottn

Thank you! Updated in https://github.com/braid-org/braid-spec/pull/113/commits/1889b9fd6548dad60b10be687e1522ab1b9bb94c.

toomim avatar Aug 19 '23 02:08 toomim