Bogdan Pintea

Results 50 comments of Bogdan Pintea

@alex-spies > No matter what we'd do about the types, the expression to_dateperiod(x) will always be wrong I'm just wondering if we have an established priorities list of failures: `FROM...

> I was trying to think of a way to solve this without adding special casing to union types' resolution. But I don't think it's really possible, and after some...

> for example string + string may lead people to thinking about string operations like Concat Indeed. string + string resulting in a datetime _is_ surprising. > We can remove...

I guess we'll also want to update the table [here](https://www.elastic.co/guide/en/elasticsearch/reference/master/esql-implicit-casting.html#_implicit_casting_support), to include grouping function(s)?

>> I guess we'll also want to update the table [here](https://www.elastic.co/guide/en/elasticsearch/reference/master/esql-implicit-casting.html#_implicit_casting_support), to include grouping function(s)? > Yes, this table is updated by this PR. Sorry, I wasn't clear enough. The...

@elasticmachine update branch

> But some csv-spec tests would help greatly: Thanks for the suggestion. I've added your proposals, though using actual index, to evaluate this in a multi-node test, plus their correctness,...

> the lack of csv-spec tests is a bit of a concern. I've added CSV tests now too. CSVs aren't very relevant with pure optimisations, as the results wouldn't be...

> The final block should probably look like > `task.skipTest("esql/60_usage/Basic ESQL usage output (telemetry)", "The telemetry output changed. We dropped a column. That's safe.")` @timgrein, this one line above might...