box-ui-elements icon indicating copy to clipboard operation
box-ui-elements copied to clipboard

feat(selectable): change single-click from select to navigate behind FF

Open jcamden opened this issue 3 years ago • 0 comments

LVE FF enabled: navigate-on-click

LVE FF disabled: select-on-click

I tried two other approaches in EUA:

  1. creating an alternate withItemSelection and changing onDoubleClick to onClick
    • This was not enough, as the crucial change happens here where something is assigned to onRowClick
    • We can still do the above in conjunction with these changes, but probably the best would be to wait until we redact the FF and then simply change onDoubleClick to onClick both here (makeSelectable) and there (withItemSelection).
  2. wrapping TableRow in ItemLink, but that road was hard to hoe, and maybe not the best idea (not sure how that could affect the interactivity of TableRow descendants.

Please note that this change does not accomplish what is required for Grid View to navigate on click.

Also, I'm not sure how to test this, off the top of my head.

jcamden avatar Oct 03 '22 18:10 jcamden