bottlerocket icon indicating copy to clipboard operation
bottlerocket copied to clipboard

settings: add host-containers settings extension

Open sam-berning opened this issue 1 year ago • 1 comments

Issue number:

Closes #3650

Description of changes:

Creates a host-containers settings extension.

Because host-containers still depends on the API to get settings, there are some changes in here to use the settings extension model within host-containers. This is definitely not best practice in the long run, but it should be stable for now and will be removed once we migrate host-containers to read settings from a config file instead. We can discuss whether we should wait to merge this PR until that change is in.

Testing done:

Built an aws-dev AMI and ran an instance with it. I tested both that host-containers worked as expected (considering I got into the instance via the admin container, it worked just fine) and that the settings extension gave responses as expected.

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

sam-berning avatar Feb 10 '24 02:02 sam-berning

^ fixed fmt errors

sam-berning avatar Feb 12 '24 18:02 sam-berning