bottlerocket icon indicating copy to clipboard operation
bottlerocket copied to clipboard
verified publisher icon bottlerocket-os

bootstrap-containers: migrate to using configuration file

Open jmt-lab opened this issue 2 years ago • 1 comments

Issue number: #3626

Closes #3626

Description of changes: This migrates the bootstrap-containers tool to fetch its settings via a generated toml file.

log:

  • add migrations and package changes
  • migrate bootstrap-containers to load from config file

Testing done: Tested full migration Tested with a bootstrap container ensuring it gets loaded and ran correctly

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

jmt-lab avatar Jan 22 '24 18:01 jmt-lab

Let's merge this first #3768 then rebase your PR to align on 1.19.2

webern avatar Feb 07 '24 21:02 webern

rebase on latest

jmt-lab avatar Feb 28 '24 22:02 jmt-lab

Finished changes and testing run

jmt-lab avatar Mar 08 '24 00:03 jmt-lab

Addressed comments

jmt-lab avatar Mar 18 '24 20:03 jmt-lab

  • Adjusted template to use new if_not_null helper
  • Adjusted call to apiclient to use command() helper

Still need to remove tokio

jmt-lab avatar Mar 22 '24 22:03 jmt-lab

removed tokio

jmt-lab avatar Mar 22 '24 22:03 jmt-lab

Rebased off latest and moved migrations to 1.20.0 will rerun the tests to be safe

jmt-lab avatar Mar 26 '24 21:03 jmt-lab

Release.toml was wrong resulting in migrations not occuring, fixed this

jmt-lab avatar Mar 27 '24 23:03 jmt-lab