bottlerocket icon indicating copy to clipboard operation
bottlerocket copied to clipboard

Investigate on if k8s should still use dockershim

Open gthao313 opened this issue 2 years ago • 4 comments

The dockershim had been deprecated few years ago but we still use it. We should investigate on if we should still use it or remove it. https://kubernetes.io/blog/2020/12/02/dockershim-faq/

gthao313 avatar Jan 08 '24 23:01 gthao313

Wouldn't this be a potential breaking change?

stockholmux avatar Jan 10 '24 15:01 stockholmux

We have this change that started the cleanup:

https://github.com/bottlerocket-os/bottlerocket/pull/3135

In newer variants, we should investigate if we can stop symlinking the containerd socket.

arnaldo2792 avatar Jan 10 '24 17:01 arnaldo2792

@gthao313 what do you mean "we still use it"? We provide a symlink from dockershim.sock to containerd.sock but Bottlerocket itself doesn't depend on dockershim.sock functionality.

bcressey avatar Jan 11 '24 18:01 bcressey

I, personally, don't understand the consequence of the symlink staying. It's near zero cost and removing it might break someone. (Feel free to tell me I'm wrong because of XYZ!)

stockholmux avatar Jan 11 '24 18:01 stockholmux