driver-web icon indicating copy to clipboard operation
driver-web copied to clipboard

Added in empty catch for json_decode

Open caleuanhopkins opened this issue 7 years ago • 2 comments

Lumen and possible other setups are not having their JSON content decoded in the Symfony request. This is an attempt to capture any missed content from Symfony's request->all() method and prepare it for Botman to carry on delivering the response

caleuanhopkins avatar Nov 26 '18 08:11 caleuanhopkins

Codecov Report

Merging #19 into master will decrease coverage by 0.04%. The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #19      +/-   ##
============================================
- Coverage     53.48%   53.44%   -0.05%     
- Complexity       50       52       +2     
============================================
  Files             5        5              
  Lines           172      174       +2     
============================================
+ Hits             92       93       +1     
- Misses           80       81       +1
Impacted Files Coverage Δ Complexity Δ
src/WebDriver.php 74.4% <50%> (-0.4%) 45 <0> (+2)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 98f10f4...0199900. Read the comment docs.

codecov[bot] avatar Nov 26 '18 08:11 codecov[bot]

Not the same problem but similar and covers details about the root of the issue that spawned this PR: https://github.com/botman/botman/issues/807

caleuanhopkins avatar Nov 26 '18 08:11 caleuanhopkins