BMI323_SensorAPI icon indicating copy to clipboard operation
BMI323_SensorAPI copied to clipboard

Added matching extern C closing bracket

Open marcirsch opened this issue 2 years ago • 3 comments

Hey there! 👋

Problem

I wanted to use the bmi323 driver in a CPP project and got an unmatched bracket compiler error. Figured that it is because of the missing extern "C" { closing bracket from the end of the file.

.././drivers/bmi323/bmi323.h:54:1: note: 'extern "C"' linkage started here
   54 | extern "C" {
      | ^~~~~~~~~~
../src/SensorController.cpp:263:2: error: expected '}' at end of input
  263 | }
      |  ^
.././drivers/bmi323/bmi323.h:54:12: note: to match this '{'
   54 | extern "C" {
      |            ^

Solution

I have added the closing brackets to the end of the header files for both bmi3.h and bmi323.h which fixed the compiler errors. I guess the intention was to enclose all function declarations, but let me know if it should be moved. 🙂

Cheers

marcirsch avatar Feb 06 '24 10:02 marcirsch

@kegov @BST-Github-Admin Cannot add reviewers, so tagging you here

marcirsch avatar Feb 07 '24 07:02 marcirsch

@marcirsch , thanks for bringing this to our attention. Let me check if we already have a newer version with this issue patched.

kegov avatar Feb 07 '24 08:02 kegov

@kegov Do you have any update on this PR?

marcirsch avatar Feb 20 '24 08:02 marcirsch