gtsfm icon indicating copy to clipboard operation
gtsfm copied to clipboard

Interface between loaders and `GtsfmData`

Open travisdriver opened this issue 4 years ago • 2 comments

this seems like this is a more general purpose function that should go into GtsfmData or something, like

class GtsfmData:
     @classmethod
     def from_colmap_model(cls, colmap_model_dir: str) -> "GtsfmData":

would that make sense?

Originally posted by @johnwlambert in https://github.com/borglab/gtsfm/pull/258#discussion_r701511870

travisdriver avatar Sep 05 '21 16:09 travisdriver

I think this is a good idea. However, I think the GtsfmData class needs to be restructured slightly for the loaders to be able to utilize it (e.g., storing image names for reading, loaders store calibrations and extrinsics separately in lists while GtsfmData stores a Dict of PineholeCameraCal3Bundler).

travisdriver avatar Sep 05 '21 16:09 travisdriver

https://github.com/borglab/gtsfm/pull/258#discussion_r705441761

travisdriver avatar Sep 09 '21 15:09 travisdriver