borgbase
Output from initializing a new repository is discarded before it can be read
Describe the bug When adding a new repository, the result is visible only for a very short time before the dialog closes. I could see there was some string beginning with "WARNING", but I have no idea about what it wanted me to warn about.
To Reproduce Steps to reproduce the behavior:
- Go to 'Repository'
- Click on 'Initialize New Repository'
- Fill in everything and click 'Add'
- There are messages shown at the bottom but only for a very short time. It would be great if they were persisted until the user manually closes the dialog.
Desktop (please complete the following information):
- OS: Arch
When adding the repo succeeds, the dialog will close. When there is a failure you can view the error message. The warning is usually about adding a new SSH key.
As a feature idea, it could show the server key for validation.
Otherwise the dialog ONLY closes if the command is successful.
@m3nu It's just not very reassuring when you see the word "WARNING" in capitals while doing something security critical and then you're not able to see what this warning was about. I'm not only interested in successfully adding the repository, but also in doing it in a secure way. If you're absolutely sure there are no relevant warnings in the success case, I'd suggest not showing them at all. If there might be relevant warnings, I'd argue for making them readable.
Absolutely agree. There is always a trade-off between keeping it simple and showing more details. For this case I see two options:
- Keep it simple and hide that one warning about adding the new SSH key.
- Make it more verbose and ask the user to validate the SSH server key when first connecting.
I encountered the brief flashing error message when trying to initialize a new repository. Before it displays "Unable to add your repository" there is an error about an invalid encryption choice, which I just can't decipher quickly enough. My encryption of choice was the default setting Repokey-Blake2.
You're probably running an older 1.0.x Borg version without Repokey-blake2 support.
The full log output is always available in
- Linux:
$HOME/.cache/Vorta/log - macOS:
$HOME/Library/Logs/Vorta
To address the issues you all brought up, I suggest the following changes:
- [ ] Remove final "Unable to add your repository" message and show last Borg error message.
- [ ] Explicitly hide Warning on new SSH key added.