fix #535

Sep 26 '22 19:09 alandefreitas

GCOVR code coverage report https://568.url.prtest.cppalliance.org/gcovr/index.html
LCOV code coverage report https://568.url.prtest.cppalliance.org/genhtml/index.html

Sep 26 '22 19:09 cppalliance-bot

An automated preview of the documentation is available at https://568.url.prtest.cppalliance.org/libs/url/doc/html/index.html

Sep 26 '22 19:09 cppalliance-bot

I believe the new rules for query/params_ref broke something with magnet. For instance,

    auto xt = m.exact_topics();
    for (auto h : xt)
        std::cout << "topic: " << h << "\n";

is now creating a url_view to the wrong address, even before removing MutableString, but I still not being able to figure out why.

Sep 26 '22 20:09 alandefreitas

An automated preview of the documentation is available at https://568.url.prtest.cppalliance.org/libs/url/doc/html/index.html

Sep 26 '22 20:09 cppalliance-bot

GCOVR code coverage report https://568.url.prtest.cppalliance.org/gcovr/index.html
LCOV code coverage report https://568.url.prtest.cppalliance.org/genhtml/index.html

Sep 26 '22 20:09 cppalliance-bot

Codecov Report

Merging #568 (fe62aeb) into develop (1fab18b) will increase coverage by 0.00%. The diff coverage is n/a.

:exclamation: Current head fe62aeb differs from pull request most recent head bd4ce2b. Consider uploading reports for the commit bd4ce2b to get more accurate results

Additional details and impacted files

@@           Coverage Diff            @@
##           develop     #568   +/-   ##
========================================
  Coverage    96.81%   96.81%           
========================================
  Files          139      139           
  Lines         6688     6691    +3     
========================================
+ Hits          6475     6478    +3     
  Misses         213      213

Impacted Files	Coverage Δ
include/boost/url/url.hpp	`100.00% <0.00%> (ø)`
include/boost/url/url_base.hpp	`100.00% <0.00%> (ø)`
include/boost/url/url_view.hpp	`100.00% <0.00%> (ø)`
include/boost/url/static_url.hpp	`80.00% <0.00%> (ø)`
include/boost/url/ipv4_address.hpp	`100.00% <0.00%> (ø)`
include/boost/url/ipv6_address.hpp	`100.00% <0.00%> (ø)`
include/boost/url/impl/url_base.ipp	`99.02% <0.00%> (ø)`
include/boost/url/url_view_base.hpp	`100.00% <0.00%> (ø)`
include/boost/url/impl/url_view_base.ipp	`98.59% <0.00%> (ø)`
include/boost/url/impl/url_view.ipp	`96.15% <0.00%> (+0.50%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1fab18b...bd4ce2b. Read the comment docs.

Sep 26 '22 20:09 codecov[bot]

I believe the new rules for query/params_ref broke something with magnet.

That suspicion was correct. The old interface that returned string views cannot work anymore because params return references to temporary strings that don't exist after the view is dereferenced.

Everything should be good now.

Sep 26 '22 21:09 alandefreitas

An automated preview of the documentation is available at https://568.url.prtest.cppalliance.org/libs/url/doc/html/index.html

Sep 26 '22 21:09 cppalliance-bot

GCOVR code coverage report https://568.url.prtest.cppalliance.org/gcovr/index.html
LCOV code coverage report https://568.url.prtest.cppalliance.org/genhtml/index.html

Sep 26 '22 21:09 cppalliance-bot

An automated preview of the documentation is available at https://568.url.prtest.cppalliance.org/libs/url/doc/html/index.html

Oct 05 '22 15:10 cppalliance-bot

GCOVR code coverage report https://568.url.prtest.cppalliance.org/gcovr/index.html
LCOV code coverage report https://568.url.prtest.cppalliance.org/genhtml/index.html

Oct 05 '22 15:10 cppalliance-bot

good to go if you think its ready