ublas Incorrect parameter ordering in element

The parameter ordering of a call to element_wise within one of the element_sub overloads is incorrect.

Since the function signature of element_wise is:

void element_wise(ublas::matrix<T, L1, opencl::storage> const &a,
	ublas::matrix<T, L2, opencl::storage> const &b,
	ublas::matrix<T, L3, opencl::storage> &result,
	O op, compute::command_queue& queue)

The call in the first element_sub overload should be changed to: element_wise(a, b, result, compute::minus<T>(), queue); as opposed to element_wise(a, b, compute::minus<T>(), result, queue);

Aug 17 '21 23:08 isaac868

I have submitted a pr that had passed the checks. Can someone review it so it can be merged?

Dec 30 '21 12:12 harjot20022001

Is there any ongoing effort to solve this issue? If not, I am interested in working on it. Please assign the task to me

Jan 09 '22 14:01 Neel-Shah-29

Is this issue resolved or yet remaining to be solved?

Feb 13 '22 09:02 Neel-Shah-29

It is not resolved yet. It appears there is are two prq's for this at https://github.com/boostorg/ublas/pull/128 and https://github.com/boostorg/ublas/pull/146#pullrequestreview-881028899. However, they need two people with write access to approve them. The one wihtout all the merge conflicts should probably be the one merged into the develop branch.

Feb 13 '22 18:02 isaac868

Incorrect parameter ordering in element_sub