ublas icon indicating copy to clipboard operation
ublas copied to clipboard

Use of Template Type in the Wrong Place

Open amitsingh19975 opened this issue 4 years ago • 4 comments

The template type, which is used for the type of extents harder coded to std::size_t instead of using the template type provided by the user. The user-provided type is misused to define the size of the static rank extents.

Link to the bug.

Fix:

template <integral T, T N>
class extents_core<T,N> {
public:  
       using base_type       = std::array<T,N>;
....
}

amitsingh19975 avatar Jun 04 '21 16:06 amitsingh19975

Hi, I would like to work on this.

shivamt2 avatar Jun 28 '21 13:06 shivamt2

Go ahead.

amitsingh19975 avatar Jun 28 '21 13:06 amitsingh19975

Can I try to solve this issue? Also guide me once through the issue that we need to replace std::size_t to the template type provided by the user in all the files right?

Neel-Shah-29 avatar Feb 10 '22 14:02 Neel-Shah-29

Can I try to solve this issue? Also guide me once through the issue that we need to replace std::size_t to the template type provided by the user in all the files right?

It will be fixed with the bug fix for the extents. So, there's no need for it.

amitsingh19975 avatar Feb 10 '22 15:02 amitsingh19975