stacktrace icon indicating copy to clipboard operation
stacktrace copied to clipboard

gcc warnings with -Wshadow compiler flag

Open nigels-com opened this issue 2 years ago • 0 comments

Looking at safe_dump_to.hpp there is a recurring pattern there of doing:

        typedef boost::stacktrace::detail::native_frame_ptr_t native_frame_ptr_t;

Which is understandable, on the face of it, improving clarity.

On the other hand, our codebase is using -Wshadow compiler flag on Linux and it is complaining about this in boost::stacktrace eventhough it's arguably a false alarm.

But looking more closely, we're already in the boost::stacktrace::detail namespace, are these additional typedefs still necessary?

nigels-com avatar Sep 05 '23 23:09 nigels-com