Make boost::iostreams::detail::path constructible from std::filesystem::path

Open nikola-sh opened this issue 5 years ago • 7 comments

Feb 27 '20 10:02 nikola-sh

Codecov Report

Merging #110 into develop will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop     #110   +/-   ##
========================================
  Coverage    68.84%   68.84%           
========================================
  Files           80       80           
  Lines         3444     3444           
  Branches      1027     1027           
========================================
  Hits          2371     2371           
  Misses         454      454           
  Partials       619      619

Impacted Files	Coverage Δ
include/boost/iostreams/detail/path.hpp	`77.27% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bc86890...126d851. Read the comment docs.

Feb 27 '20 11:02 codecov[bot]

@jeking3 Take a look at this PR please

Mar 02 '20 12:03 nikola-sh

@mclow Take a look at this PR please

May 17 '20 19:05 nikola-sh

I don't see any tests for this new functionality. The code looks reasonable, but w/o tests, do we know that it works?

May 18 '20 14:05 mclow

@mclow I have added a test. PR is failed because one job is failed with error Error: retrieving gpg key timed out. Could you review a code and rerun failed job?

May 19 '20 18:05 nikola-sh

@mclow Take a look at this PR again please

May 28 '20 12:05 nikola-sh

any update on this one?

Sep 20 '23 06:09 timblechmann