FDboost icon indicating copy to clipboard operation
FDboost copied to clipboard

Fix CI

Open davidruegamer opened this issue 3 years ago • 6 comments

Currently an old setup for Travis CI is used and hence automatic checks are broken.

davidruegamer avatar Jul 12 '22 09:07 davidruegamer

Currently an old setup for Travis CI is used and hence automatic checks are broken.

You open for using GitHub Actions? Then I could provide a PR.

m-muecke avatar Mar 19 '25 22:03 m-muecke

Yes and thank you! That would be awesome!

davidruegamer avatar Mar 19 '25 22:03 davidruegamer

Yes and thank you! That would be awesome!

Ok, great! You open for using testthat for testing? It's currently already in suggest, but afaik not really used.

m-muecke avatar Mar 20 '25 09:03 m-muecke

IIRC, we didn't use testthat because our tests take a long time. I would have to think about how to simplify them to avoid long CI waiting times.

davidruegamer avatar Mar 20 '25 11:03 davidruegamer

IIRC, we didn't use testthat because our tests take a long time. I would have to think about how to simplify them to avoid long CI waiting times.

What I generally do, when the tests are running too long for the CI is to add a skip call, e.g. skip_on_ci() and skip_on_cran()

m-muecke avatar Mar 20 '25 11:03 m-muecke

Good idea. Another option would be to skip all the factorization tests from @Almond-S and let the boosting routines in general_tests only run for one iteration via control = boost_control(mstop = 1). Since we do not do any type checking in this file, I guess we could go with tests that simply check for no error

davidruegamer avatar Mar 20 '25 21:03 davidruegamer