boa icon indicating copy to clipboard operation
boa copied to clipboard

Mark `JsNativeError`'s constructors const

Open CrazyboyQCD opened this issue 1 year ago • 1 comments

Use constant to reduce binary size. https://godbolt.org/z/YEq4hW49n

CrazyboyQCD avatar Oct 17 '24 03:10 CrazyboyQCD

Codecov Report

Attention: Patch coverage is 48.57143% with 18 lines in your changes missing coverage. Please review.

Project coverage is 52.85%. Comparing base (6ddc2b4) to head (23c6c1a). Report is 282 commits behind head on main.

Files with missing lines Patch % Lines
core/engine/src/error.rs 54.83% 14 Missing :warning:
core/engine/src/builtins/temporal/error.rs 0.00% 4 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4020      +/-   ##
==========================================
+ Coverage   47.24%   52.85%   +5.60%     
==========================================
  Files         476      482       +6     
  Lines       46892    46723     -169     
==========================================
+ Hits        22154    24695    +2541     
+ Misses      24738    22028    -2710     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 17 '24 03:10 codecov[bot]

@jasonwilliams you pinged a random user 😅

jedel1043 avatar Nov 02 '24 18:11 jedel1043