boa icon indicating copy to clipboard operation
boa copied to clipboard

Address `Panics` in `boa_engine`

Open nekevss opened this issue 2 years ago • 1 comments

Related to #3235.

With Rust v1.72, clippy began linting any panics that have missing panics documentation.

Some potential approaches to addressing the panics are: remove the panics and update them to return a RuntimeError/ImplementationError or add the documentation to the function that identified as panicking, or a combination of the two of those.

#3235 disables the lint, but the panics should be addressed and the lint reenables.

nekevss avatar Aug 26 '23 22:08 nekevss

Seeing that some language engines such as Rhai have a Don't Panic guarantee as a feature, maybe we should consider migrating to an ImplementationError as you've said, instead of panicking everywhere.

jedel1043 avatar Sep 07 '23 01:09 jedel1043