gapstone icon indicating copy to clipboard operation
gapstone copied to clipboard

Make gapstone go-get-able without pre-installing Capstone.

Open BenLubar opened this issue 7 years ago • 2 comments

Also fixes tests failing on Windows due to line endings in .SPEC files.

Tested on Windows 10 (mingw-gcc 5.3, Go 1.11beta2) and Ubuntu 18.04 (gcc 7.3, Go 1.10.3).

BenLubar avatar Jul 31 '18 13:07 BenLubar

Hi! Thanks for the code. If you can fix the CI errors then I'm OK to merge this. Looks like it's just breaking on old go?

bnagy avatar Sep 03 '18 22:09 bnagy

@bnagy Looking at the build errors I see this

The command "eval go get -t -v ./... " failed. Retrying, 2 of 3.

It seems like maybe Travis CI just had some connectivity issues. Would you be able to retry the build and see if it builds and tests cleanly?

I think this PR is a nice improvement and would be in favor of merging it.

knightsc avatar Feb 02 '19 17:02 knightsc