twistar Proper transactions

As promised: Transactions which actually run in db threads. Supports fake nesting, SAVEPOINTs and can be used as context managers.

Oct 19 '16 16:10 sehoffmann

Hey @Paranaix - thanks for the contribution! I'd be happy to merge, but I think the tests on CI are failing with these changes (though at first glance, I think it's just a linting issue).

Oct 31 '16 13:10 bmuller

Sorry for the late reply, I was kind of the busy.

I already fixed this; however I ammended the commit and did a force push. Unfortunately travis CI doesn't seem to recognize the new commit. If you take a look at the travis build you will see that it still shows 5508348 and not 8310e31.

You can checkout the PR yourself and run the tests manually and they should pass IIRC.

Nov 14 '16 19:11 sehoffmann

Hey @Paranaix - I think there are still a few issues. For instance this line still imports twisted.internet.reactor which isn't used.

Nov 14 '16 20:11 bmuller

Ok, I'll have another look at it today or tommorrow

Nov 15 '16 09:11 sehoffmann