IGDIPlus icon indicating copy to clipboard operation
IGDIPlus copied to clipboard

MakeColor(clMaroon) make a GRAYSCALE color

Open AndrewBJ opened this issue 1 year ago • 3 comments

The problem with a clMaroon parameter which is TColor but a function (AGrayScale : Byte) called

function  MakeColor( AColor : TColor ) : TAlphaColor; overload;
function  MakeColor( AGrayScale : Byte ) : TAlphaColor; overload;

I think a grayscale functions should have a different name

AndrewBJ avatar Jul 05 '24 18:07 AndrewBJ

Thank you! What name you would propose? I have not had issues with the function name, but open to suggestions :-)

bmitov avatar Jul 05 '24 18:07 bmitov

there is already a function function MakeGrayScaleColor( AAlpha : Byte; AColor : Byte ) : TAlphaColor; I think this particular function can be overloaded by the version without the Alpha parameter

AndrewBJ avatar Jul 05 '24 19:07 AndrewBJ

Hi. Check a pullrequest please. Fixed a work with sets (critical) and grayscale conversion functions naming

AndrewBJ avatar Jul 31 '24 06:07 AndrewBJ