vscode-intelephense icon indicating copy to clipboard operation
vscode-intelephense copied to clipboard

Really need to go parent define and go to implements for property and method.

Open xpader opened this issue 4 years ago • 4 comments

We can use Find All References and Find All Implements, but this is only search down implements.

We really need up search override property and method where it's define.

Hope we can have up search and down search for property and method.

Screenshot in phpStorm:

屏幕截图 2021-03-29 120220 屏幕截图 2021-03-29 120139

xpader avatar Mar 29 '21 06:03 xpader

Does go to declaration resolve this?

go_to_declaration

bmewburn avatar Mar 29 '21 08:03 bmewburn

Not just like that, It can go up and up again by click the method or property. For example, you can click foo() in SubType to found up define in SuperType just like click parent::foo(), not the instance of SubType.

These really help for read framework codes, or implement Class.

phpstorm

xpader avatar Mar 30 '21 06:03 xpader

Sounds like type/method hierarchy support. I don't think this has been specified in the Language Server Protocol yet. There's an issue tracking it here https://github.com/microsoft/language-server-protocol/issues/136 .

bmewburn avatar Mar 30 '21 08:03 bmewburn

I think they support it now.

mrcwebdesign avatar Dec 14 '23 19:12 mrcwebdesign

@bmewburn Consider to implement this?

xpader avatar Jun 14 '24 03:06 xpader

@xpader looking into it but there's a few challenges in that vscode/lsp does not have an api for it yet. will track this in #1249

bmewburn avatar Jun 14 '24 05:06 bmewburn