vscode-intelephense Symbol is declared but not used.intelephense(1003)

Describe the bug The extension does not see the use of a private property

To Reproduce

<?php

class One {

	private $helpers;

	private function __construct() {
		$this->helpers = 10;
	}
}

For me in this code Intelephense show warning on $helpers - Symbol '$helpers' is declared but not used.intelephense(1003) But i use it and code works as expevted. What am i missing? Why $hepleprs become used if it is of type protected?

Expected behavior I expect $helper prop not to be grayed as not in use.

Screenshots

Platform and version Win 10. Intelephense 1.5.4.

Nov 20 '20 10:11 outcomer

In the example private $helpers is written to but never read, therefore could safely be removed from the class. When protected it is possible it is used outside of the class.

Nov 22 '20 03:11 bmewburn

@bmewburn Ah that is the case! The property is considered as usable if it been read. But in example i write value (10) into it. I would like to discuss a real case and get your opinion. So if i remove like this

class One {
	private function __construct() {
		$this->helpers = 10;
	}
}

then PHP auto declare it by default as public and everybody will get read/write access to it.

What i am doing (tbh this is common pattern - getter/setter):

class One {

        private $helpers;

	private function __construct() {
		$this->helpers = new ClassHelpers();
	}

	public function get_module( $module_name ) {
		return $this->{$module_name};
	}
}

On runtime get_module invokes like this One->get_module('helpers'); So it returns $this->helpers. It could be declared directly like this:

public function get_helpers() {
	return $this->helpers;
}

And prop would be in use, cause i read it. But i have about 150 modules so it is headache to not to forget to write getter for each prop. If this a big problem to recognize that $this->helpers in fact uses via $this->get_module()? Or do you think this code architecture is wrong?

Nov 22 '20 11:11 outcomer

Thanks for the example. You're right, it shouldn't report this if there is dynamic property access.

Nov 24 '20 02:11 bmewburn

@bmewburn Thanks!

Nov 24 '20 11:11 outcomer

This is very common in SilverStripe as the ORM defines its database fields with private static $db = ...; along with a lot of other private static fields.

https://docs.silverstripe.org/en/4/developer_guides/model/how_tos/dynamic_default_fields/

Would be good to add exceptions to the "unused" rule, as there is usually between 3 and 6 private static fields per data object class implementation.

Jan 25 '21 04:01 OldStarchy

I am having the 1003 issue but with a different aspect: In this case Intelephense is thinking that Exception is part of the namespace even though it is not. If I switch it to \ then I get this