MDL-55170 - Fix user enrollment dialog, RTL.

[gjb2048]

Hi Bas,

More of a question to see if the theme needs this patch?

Cheers,

Gareth

[bmbrands]

I think theme_bootstrap needs lots of fixes for RTL languages. I am still hoping for an automated solution instead of adding rtl less. So will keep this open for now.

I did track down the less created by Nadav and added it here for later reference.

.dir-rtl {
    &#page-enrol-users {
        .col_userdetails {
            .subfield {
                margin-right: 40px;
                margin-left: 5px;
            }
            .subfield_picture {
                float: right;
                margin-right: 0;
            }
        }
        .enrol_user_buttons {
            float: left;
            .enrolusersbutton {
                margin-left: 0;
                margin-right: 1em;
                div {
                    margin-left: 0;
                }
            }
        }
        #filterform {
            .fitem {
                margin-right: 0;
                margin-left: .3em;
                label {
                    padding-right: 0;
                    padding-left: .3em;
                }
            }
        }
        .user-enroller-panel .uep-search-results .user {
            .count, .picture, .details {
                float:right;
            }
            .options .enrol {
                float:left;
            }
        }
    }
}

[gjb2048]

Hi Bas,

Yeah, I see. Complicated and time consuming stuff, which is why I removed the auto-flip in Essential for M3.1. Hopefully https://tracker.moodle.org/browse/MDL-55224 will help in the future.

I think the key thing here is feedback from RTL users. Nadav is excellent at testing for this.

G