csvutil icon indicating copy to clipboard operation
csvutil copied to clipboard

Tests don't compile

Open 0x6e6562 opened this issue 11 years ago • 2 comments

I'm not sure whether the Go standard library has changed since this library was written, but I seem to get the following compile errors for the test suite:

➜  csvutil git:(master) go version
go version go1.2 darwin/amd64
➜  csvutil git:(master) go test -v
# _/Users/0x6e6562/Workspace/golang/src/github.com/bmatsuo/csvutil
./config_test.go:31: undefined: utf8.NewString
./file_test.go:17: undefined: os.ENOENT
./file_test.go:21: statErr.String undefined (type error has no field or method String)
./file_test.go:25: rmErr.String undefined (type error has no field or method String)
./file_test.go:40: cannot use TestPerm (type uint32) as type os.FileMode in function argument
./file_test.go:65: cannot use TestPerm (type uint32) as type os.FileMode in function argument
./file_test.go:71: err.String undefined (type error has no field or method String)
./reader_test.go:86: err.String undefined (type error has no field or method String)
./writer_test.go:21: err.String undefined (type error has no field or method String)
FAIL    _/Users/0x6e6562/Workspace/golang/src/github.com/bmatsuo/csvutil [build failed]

0x6e6562 avatar Mar 05 '14 18:03 0x6e6562

Ah. Yes. This is due to some changes in the standard library long ago. This package needs some love. But I have a new project that could make use of this. So I'll put in some time this week to bring it up to snuff.

Thanks for bringing this to my attention.

bmatsuo1 avatar Mar 05 '14 19:03 bmatsuo1

Thanks for the heads up - it's good to see that you'll re-live this project :-)

Right now I have a problem that this library solves to about 80% - what is missing is date parsing and being able to handle null fields. So if this is brought into a maintained state, I'd consider going ahead with it.

0x6e6562 avatar Mar 05 '14 20:03 0x6e6562