name-db icon indicating copy to clipboard operation
name-db copied to clipboard

Added languages dict for convenience.

Open EmilLuta opened this issue 8 years ago • 7 comments

Added languages for easier lookup instead of the wiki's nasty pages and links (found them discouraging) + it helps me automate my overall crawling task (so I can properly check for languages, if they exist).

EmilLuta avatar Oct 26 '17 18:10 EmilLuta

Hey @EmilLuta,

Once question: Are you sure that this is a complete list of all the languages? I mean, I've noticed that there are some missing dialects, don't you think these are important? For instance, you only included ara as Arabic, but what if there's a difference in the way you pronounce a certain name in different dialects of Arabic?

What do you think?

bluzi avatar Oct 27 '17 15:10 bluzi

@bluzi I've also been thinking about that. My judgement at that time was:

  1. I strongly felt that dialects had same names.
  2. Easier to scrape.
  3. Couldn't find a single counter-example to 1.

As far as it is concerned, I'm flexible about it.

P.S. What about the extra branch where we can keep the current scraper?

EmilLuta avatar Oct 27 '17 15:10 EmilLuta

Hey @EmilLuta,

I made you a collaborator, so you can create a branch.

bluzi avatar Oct 28 '17 17:10 bluzi

@bluzi Sorry for the high off-time, been in a holiday.

I can't push already, did you give me write access?

Also, I believe we should make a decision with this PR. Either 'fix' it or close it. Let me know how you'd like to process. I'll move forward with the scraper.

EmilLuta avatar Oct 30 '17 06:10 EmilLuta

Hi @EmilLuta, looks like you haven't approved the invitation.

image

Click here and approve it.

bluzi avatar Oct 30 '17 15:10 bluzi

@bluzi You were right. I've been a bit clumsy. On this note, I'll need to have a small chat with you on my latest PR (functionality wise).

On a side note, I could give you a hand of help with closing PRs, as long as you communicate clearly your expectations from a PR. Let me know what you think.

EmilLuta avatar Oct 31 '17 13:10 EmilLuta

@EmilLuta Sure, feel free to add me on Hangouts. eliran013 AT gmail.com (Replace AT with @ of course :))

bluzi avatar Oct 31 '17 14:10 bluzi