Piyush Vashisht

Results 33 comments of Piyush Vashisht

The option to toggle the theme is present in storybook but absent in documentation site

Also I think using the word 'system' instead of `theme` would be more precise and will be more easier to understand because in storybook as well we are using `system`...

> @blunteshwar Can we add how have PR reviewers manually test this in the instructions? Something along the lines of going to storybook and use the color components with different...

> Just a minor change or two in the docs and we're good to go. Can you point out those changes in docs?

> * Storybook Thank you for pointing this out. This has been fixed now. You can check and verify with the storybook link in the pr. The problem occurred because...

> I left one question here, @blunteshwar. An additional thought I had was if you need to account for the [fixed version numbers that you publish at](https://github.com/changesets/changesets/blob/main/docs/fixed-packages.md). Spectrum CSS doesn't...

> Also, sorry for being late to the review, but can we still separate ignored packages and the getWorkspacePackages function to their own file? Perhaps in a utility folder inside...

> @blunteshwar Pull this up to `main` and we can merge this! Done!