BlueOS
BlueOS copied to clipboard
Remove timestamp from entrypoint log file
Timestamps are added in archives on rotation, the entrypoint having a timestamp creates an awkward situation where the log messages timestamp and log file name drift apart.
( currently entrylog name and rotation routine are not related )
Summary by Sourcery
Enhancements:
- Simplify log file naming by removing datetime information from the filename
Reviewer's Guide by Sourcery
This pull request removes the timestamp from the entrypoint log file name. The timestamp is added during log rotation, so it is redundant to have it in the entrypoint log file name.
Updated class diagram for logs
classDiagram
class logs.py {
<<file>>
+get_new_log_path(service_name: str) Path
+init_logger(service_name: str) None
}
note for logs.py "Removes timestamp from entrypoint log file name"
File-Level Changes
| Change | Details | Files |
|---|---|---|
| Removed timestamp from the entrypoint log file name. |
|
core/libs/commonwealth/commonwealth/utils/logs.py |
Tips and commands
Interacting with Sourcery
-
Trigger a new review: Comment
@sourcery-ai reviewon the pull request. - Continue discussions: Reply directly to Sourcery's review comments.
-
Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it. You can also reply to a
review comment with
@sourcery-ai issueto create an issue from it. -
Generate a pull request title: Write
@sourcery-aianywhere in the pull request title to generate a title at any time. You can also comment@sourcery-ai titleon the pull request to (re-)generate the title at any time. -
Generate a pull request summary: Write
@sourcery-ai summaryanywhere in the pull request body to generate a PR summary at any time exactly where you want it. You can also comment@sourcery-ai summaryon the pull request to (re-)generate the summary at any time. -
Generate reviewer's guide: Comment
@sourcery-ai guideon the pull request to (re-)generate the reviewer's guide at any time. -
Resolve all Sourcery comments: Comment
@sourcery-ai resolveon the pull request to resolve all Sourcery comments. Useful if you've already addressed all the comments and don't want to see them anymore. -
Dismiss all Sourcery reviews: Comment
@sourcery-ai dismisson the pull request to dismiss all existing Sourcery reviews. Especially useful if you want to start fresh with a new review - don't forget to comment@sourcery-ai reviewto trigger a new review! -
Generate a plan of action for an issue: Comment
@sourcery-ai planon an issue to generate a plan of action for it.
Customizing Your Experience
Access your dashboard to:
- Enable or disable review features such as the Sourcery-generated pull request summary, the reviewer's guide, and others.
- Change the review language.
- Add, remove or edit custom review instructions.
- Adjust other review settings.
Getting Help
- Contact our support team for questions or feedback.
- Visit our documentation for detailed guides and information.
- Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.