bluehost-wordpress-plugin icon indicating copy to clipboard operation
bluehost-wordpress-plugin copied to clipboard
verified publisher icon bluehost

Adds code standard checking

Open bradp opened this issue 1 year ago • 3 comments

This is a replacement for #851

This adds the files and configurations for code standards and linting. Another PR based off this branch will include the first round of fixes for it.

  • Adds .editorconfig to make things consistent

  • Adds .phpcs.dist.xml and .php-cs-fixers.dist.php for PHP linting

  • Adds jsconfig.json to allow IDE eslint to correctly associate aliases

  • Updates Composer and NPM commands to include linting

bradp avatar Mar 27 '24 20:03 bradp

Bluehost Brand Plugin    Run #10918

Run Properties:  status check failed Failed #10918  •  git commit 90e20d67e6 ℹ️: Merge a2dc9eafe0b973b00170052b6a9e2f3b36d6cb51 into f94f7e89f4c720149255a8f25847...
Project Bluehost Brand Plugin
Branch Review feature/code-standards-2
Run status status check failed Failed #10918
Run duration 36m 45s
Commit git commit 90e20d67e6 ℹ️: Merge a2dc9eafe0b973b00170052b6a9e2f3b36d6cb51 into f94f7e89f4c720149255a8f25847...
Committer Brad Parbs
View all properties for this run ↗︎
Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 36
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 416
View all changes introduced in this branch ↗︎

Tests for review

Failed  vendor/newfold-labs/wp-module-migration/tests/cypress/integration/Migration/landIntoMigrationFromAM.cy.js • 1 failed test

View Output Video

Test Artifacts
Verify Migration- emulating AM flow > Verify Migration page is loaded Test Replay Screenshots Video

cypress[bot] avatar Mar 27 '24 20:03 cypress[bot]

Bluehost Brand Plugin    Run #10903

Run Properties:  status check failed Failed #10903  •  git commit a2dc9eafe0: Actually run both commands
Project Bluehost Brand Plugin
Branch Review feature/code-standards-2
Run status status check failed Failed #10903
Run duration 31m 18s
Commit git commit a2dc9eafe0: Actually run both commands
Committer Brad Parbs
View all properties for this run ↗︎
Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 36
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 416
View all changes introduced in this branch ↗︎

Tests for review

Failed  vendor/newfold-labs/wp-module-migration/tests/cypress/integration/Migration/landIntoMigrationFromAM.cy.js • 1 failed test

View Output Video

Test Artifacts
Verify Migration- emulating AM flow > Verify Migration page is loaded Test Replay Screenshots Video

cypress[bot] avatar Mar 27 '24 21:03 cypress[bot]

Checks failing are to be expected until #852 is merged into this branch.

bradp avatar Oct 02 '24 00:10 bradp

Based on the lack of updates on this and the now number of conflicts, I think we can close this and reopen or restart if we have the need in the future.

circlecube avatar Nov 12 '24 21:11 circlecube