Why is SparkJobServerClientImpl package-private?

Open yatszhash opened this issue 8 years ago • 1 comments

I infer that because of using factory pattern and cache connection. However, it's very inconvenient to implement customized client because it cannot be extended and it's very redundant to write the common processes from scratch.

I think this library's aim to reduce such redundancy. To reduce this convenience can I extract the method implementation of SparkJobServerClientImpl into an abstract class?

Mar 10 '17 04:03 yatszhash

@yatszhash Current design purpose is just like your assumption, the setting of SparkJobServerClientImpl as package-private is just for the factory pattern and cache. Just like your advice, it may consider the custom-defined way.

Now the version 1.0.0 of 'spark-job-server-client' under the group id of 'com.bluebreezecf' has been published to Central Repository.

I will consider your kind advice and make some necessary modification in its next release.

Apr 23 '17 15:04 bluebreezecf