react-bluekit icon indicating copy to clipboard operation
react-bluekit copied to clipboard

PropTypes generated by Object.keys are wrapped with double quotes

Open JamesPlayer opened this issue 8 years ago • 0 comments

If I have a component that has a PropType of oneOf, the array is generated using Object.keys ie:

const icons = {
  trash: '...',
  tag: '...',
  tagMerge: '...',
  ...
};

Icon.propTypes = {
  icon: PropTypes.oneOf(Object.keys(icons)),
  ...
};

In BlueKit each icon in the enum dropdown is wrapped with double quotes, which stops the preview from working:

screen capture on 2017-12-20 at 10-14-52

I can see in the componentsIndex.js that it's been generated with the quotes:

propsDefinition: {icon:{type:{name:"enum",value:[{value:"\"trash\"",computed:false},{value:"\"tag\"",computed:false},{value:"\"tagMerge\"",computed:false} ...

Please look into it, thanks!

JamesPlayer avatar Dec 19 '17 21:12 JamesPlayer