cli icon indicating copy to clipboard operation
cli copied to clipboard

alternate branch tag generation regression relative to startingpoint

Open RoyalOughtness opened this issue 1 year ago • 8 comments

the tag generation based on other branch names is broken:

https://github.com/secureblue/secureblue/pkgs/container/silverblue-main-hardened/versions staging is getting published as "cd9d6ba-39 br-staging-39" instead of "39-staging" and "staging"

RoyalOughtness avatar Feb 27 '24 18:02 RoyalOughtness

I think the br- prefix makes sense here, but with the other stuff I believe I discussed this with @gmpinder earlier. Maybe here, maybe some parts where somewhere else.

Anyway, I am of the opinion that there should at least be a br-staging tag that is the same as the latest tag but for the staging branch. The necessity of that prefix can be discussed.

xynydev avatar Feb 27 '24 19:02 xynydev

I'm fine with adding an exception for staging, but we should either leave it at that extra branch name being designated for testing or allow all branches to not have a br- prefix.

gmpinder avatar Feb 27 '24 19:02 gmpinder

No need to add an exception just for us, we'll be fine without it. If the intention wasn't to preserve this functionality, then to close this ticket could be as simple as documentation for the new behavior

RoyalOughtness avatar Feb 27 '24 19:02 RoyalOughtness

We'll be sure to sign images so long as the public and private keys are accessible in the pipeline

gmpinder avatar Feb 27 '24 20:02 gmpinder

No need to add an exception just for us, we'll be fine without it. If the intention wasn't to preserve this functionality, then to close this ticket could be as simple as documentation for the new behavior

@xynydev where would this go?

gmpinder avatar Feb 27 '24 20:02 gmpinder

Not sure what you mean by that question. My earlier comment explains my stance on the topic.

xynydev avatar Feb 27 '24 21:02 xynydev

Not sure what you mean by that question. My earlier comment explains my stance on the topic.

Where would the documentation go?

gmpinder avatar Feb 28 '24 00:02 gmpinder

Either a new page in the docs, but I think it'd belong to a reference page for the cli, which has yet to be made.

Such a page should document the public API of cli in great detail. The build --push tagging info would be a part of that.

xynydev avatar Feb 28 '24 12:02 xynydev