xcdiff icon indicating copy to clipboard operation
xcdiff copied to clipboard

Update for XcodeProj with strongly typed settings

Open kwridan opened this issue 1 year ago • 1 comments

Describe your changes

  • Updates to xcdiff for compatibility with https://github.com/tuist/XcodeProj/pull/903
  • Build setting values are no longer type erased and instead can now either be a String or [String]
  • This alleviates the need to casting values and throwing errors when dealing with build settings

Test Plan

  • Verify CI passes

kwridan avatar Feb 19 '25 09:02 kwridan

Codecov Report

Attention: Patch coverage is 88.13559% with 7 lines in your changes missing coverage. Please review.

Project coverage is 97.09%. Comparing base (c48fb45) to head (1b2ac14). Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
...ffCore/Comparator/ResolvedSettingsComparator.swift 64.70% 6 Missing :warning:
Sources/XCDiffCore/Library/PBX+Extensions.swift 95.83% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #145      +/-   ##
==========================================
+ Coverage   97.05%   97.09%   +0.04%     
==========================================
  Files          52       53       +1     
  Lines        2986     3034      +48     
==========================================
+ Hits         2898     2946      +48     
  Misses         88       88              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 19 '25 10:02 codecov[bot]