quantum icon indicating copy to clipboard operation
quantum copied to clipboard

Fixed the move semantics related and other issues reported by the newer clang compiler.

Open safaruqi opened this issue 4 years ago • 3 comments

*Issue number of the reported bug or feature request: #150 *

Describe your changes Fixed all of the move semantics related and other issues reported by the newer clang compiler.

Testing performed Was able to run all the included tests successfully which tests the whole fixture and primitives.

Additional context

safaruqi avatar Sep 28 '21 00:09 safaruqi

Travis Ci passed for g++ C++ standard 11, 14, & 17. For clang it passed for C++ 14 & 17 but is failing for c++11. WIl look at it when I find some time next.

safaruqi avatar Sep 28 '21 13:09 safaruqi

@safaruqi @arosenzweig3 any updates on this merge? Seems like it's holding up some folks...

accelerated avatar Nov 29 '21 18:11 accelerated

This looks good to me, just getting another set of eyes on it before we merge.

arosenzweig3 avatar Aug 10 '22 16:08 arosenzweig3