frontend icon indicating copy to clipboard operation
frontend copied to clipboard

Make a PR to Giveth project

Open 0xdeval opened this issue 1 year ago • 3 comments

What to do?

We need to make PRs to all Giveth repos where we would change Etherscan links to Blockscout

There are 3 projects that they have:

Here is the contribution guide: https://docs.giveth.io/dapps/contributors/

The list of repos:

0xdeval avatar May 02 '24 15:05 0xdeval

  • https://github.com/Giveth/giveth-dapps-v2/pull/4206
  • https://github.com/Giveth/giveth-docs/pull/212

maxaleks avatar May 24 '24 17:05 maxaleks

Seems the Giveth team won't merge our PR. Closing the issue

0xdeval avatar Jul 18 '24 15:07 0xdeval

@maxaleks can you pls check the PR that you made previously to giveth. We need to resolve conflicts there https://github.com/Giveth/giveth-dapps-v2/pull/4206#pullrequestreview-2465679087

0xdeval avatar Nov 29 '24 03:11 0xdeval

Finally can close the issue. Was implemented and released at https://github.com/Giveth/giveth-dapps-v2/issues/4994

0xdeval avatar May 27 '25 09:05 0xdeval