administrate_ransack icon indicating copy to clipboard operation
administrate_ransack copied to clipboard

Use filter_resources instead of scoped_resource?

Open goosys opened this issue 1 year ago • 1 comments

It seems that since Administrate v0.18.0, the search processing part has been separated into filter_resources. Since Ransack is also part of the filter family, I think it would be smarter to move it to filter_resources rather than keeping it under scoped_resource. What do you think?

https://github.com/thoughtbot/administrate/blob/v0.18.0/app/controllers/administrate/application_controller.rb#L82-L88

goosys avatar Jul 30 '24 14:07 goosys

It seems that since Administrate v0.18.0, the search processing part has been separated into filter_resources. Since Ransack is also part of the filter family, I think it would be smarter to move it to filter_resources rather than keeping it under scoped_resource. What do you think?

Hey @goosys Thanks for pointing this out, it looks reasonable. I'm evaluating that change.

blocknotes avatar Apr 23 '25 21:04 blocknotes