blocknet icon indicating copy to clipboard operation
blocknet copied to clipboard

Notify user of upper limit on queryCount

Open shrnkld opened this issue 4 years ago • 0 comments

Scenario: requesting xrGetBlockCount via core console or cli with a queryCount > 50 returns an error.

xrgetblockcount BLOCK 10
{
  “reply”: 2244915,
  “uuid”: “08ae7d53-49b7-498a-8d3d-9b3ece4d8a03”
}

xrgetblockcount BLOCK 100
{
  “code”: 1032,
  “error”: “Failed to find 100 service node(s) supporting BLOCK::xrGetBlockCount with config limits, found 0”,
  “uuid”: “1933a5d2-f023-42d1-b154-8ed469d1a407”
}

To do:

  • [ ] - in xrouter.conf the following content:
#! consensus is the minimum number of nodes you want your xrouter calls to query (1 or more)
#! Paid calls will send a payment to each selected service node.
consensus=3

should be replaced by:

#! consensus is the minimum number of nodes you want your xrouter calls to query (min=1, max=50)
#! Paid calls will send a payment to each selected service node.
consensus=3
  • [ ] #609
  • [ ] return the following error msg if the user sets queryCount to > 50:
{
  “code”: 1032,
  “error”: “Your request of X nodes is too high. Please set queryCount to >0 and <51”,
}

_where X = `queryCount`_

shrnkld avatar Nov 22 '21 14:11 shrnkld