web3-onboard icon indicating copy to clipboard operation
web3-onboard copied to clipboard

Feature/sequence wallet

Open SamueleA opened this issue 3 years ago • 1 comments

Description

This features is an integration of the Sequence wallet The wallet can be accessed either as a chrome extension or through the SDK. The former integration is done through the injected wallet package and the latter through the Sequence package. If window.ethereum.isSequence is not true, the connection through the SDK will be made available since this will mean that the user does not have the chrome extension.

Notes:

  • signing message is not working on the demo app due to lack of support for EIP-1271 since Sequence uses a contract wallet. The sequence SDK provider a method sequence.utils.isValidMessageSignature which allows the signature to be verified,
  • switching to a network whose contract wallet is undeployed doesn't work sometimes/has a weird flow. This is a known issue which will be fixed on Sequence's side

Checklist

  • [x] The version field in package.json is incremented following semantic versioning
  • [x] The box that allows repo maintainers to update this PR is checked
  • [x] I tested locally to make sure this feature/fix works
  • [x] I have run yarn type-check & yarn build to confirm there are not any associated errors
  • [ ] This PR passes the Circle CI checks

SamueleA avatar Aug 10 '22 16:08 SamueleA

Hey @SamueleA thanks for the PR, we will try and get this reviewed soon.

lnbc1QWFyb24 avatar Aug 11 '22 01:08 lnbc1QWFyb24

Hey @SamueleA I am taking a look at this at the moment.

switching to a network whose contract wallet is undeployed doesn't work sometimes/has a weird flow. This is a known issue which will be fixed on Sequence's side

The wallet seems to default to Polygon, should I be able to switch to Ethereum mainnet, or does come under the known issue that you mention above? I see the wallet trigger a popup, but it sits there for a bit with a blank screen and then goes away without switching to Ethereum mainnet.

lnbc1QWFyb24 avatar Aug 17 '22 00:08 lnbc1QWFyb24

Hey @SamueleA I am taking a look at this at the moment.

switching to a network whose contract wallet is undeployed doesn't work sometimes/has a weird flow. This is a known issue which will be fixed on Sequence's side

The wallet seems to default to Polygon, should I be able to switch to Ethereum mainnet, or does come under the known issue that you mention above? I see the wallet trigger a popup, but it sits there for a bit with a blank screen and then goes away without switching to Ethereum mainnet.

Yes, that is indeed the known issue I have mentioned. The Mainnet wallet is not deployed by default, just the polygon one. So the expected behavior when switching to Mainnet would have been a flow for that scenario within the popup. Instead, the popup just closes

SamueleA avatar Aug 18 '22 20:08 SamueleA