web3-onboard icon indicating copy to clipboard operation
web3-onboard copied to clipboard

[Feature]: Magic Link more login support: Google Oauth and SMS

Open jadbox opened this issue 3 years ago • 6 comments

Is your request related to a problem?

We would like users to be able to login with social logins like Google OAuth or using Magic's SMS validation.

Feature Description

Google OAuth docs: https://magic.link/docs/login-methods/social-logins/integration/social-providers/google

SMS login docs: https://magic.link/docs/login-methods/sms/integration/web

Alternative Solutions

There is a fully prebuilt form option here, but it looks like the existing plugin would need to be refactored for it: https://magic.link/docs/login-form

Anything else?

none

jadbox avatar Jul 12 '22 04:07 jadbox

Hey @jadbox! Would this perhaps be what you're looking for?

taylorjdawson avatar Jul 12 '22 07:07 taylorjdawson

@taylorjdawson hey thanks for the inquiry. We are already using the magic module, but it does not support SMS or social login providers. That module could use the "form UI" method I mentioned above to capture all the login options to display to the user.

jadbox avatar Jul 12 '22 13:07 jadbox

@jadbox Yes our initial Magic integration was limited to just email login to start as it wasn't simple to support their other methods at the time. @Adamj1232 could take another look at this to see if there have been further developments on the magic SDK side, or if we can add to our custom UI.

lnbc1QWFyb24 avatar Jul 13 '22 02:07 lnbc1QWFyb24

@jadbox we will look into this further. Currently the login form provided by Magic is only for no-code applications and has proven very challenging to be used in a library project as URL redirects are required by the low/no-code login form. We opened a feature request with Magic a few months back that you can see here. If you could comment on this we may get some traction. We also have some of our BizDev members reaching out to push this feature along. Otherwise we will need to write our own which is fine but it would be nice to have all available login options through the form as defined by the DApp users Magic API key. If we don't hear from them shortly the approach will likely be to add a ticket to the backlog and work it when the ticket makes its way to the top.

Adamj1232 avatar Jul 14 '22 03:07 Adamj1232

We are currently working with the Magic team to land on a solution that can support all login features with Magic Link through their API

Adamj1232 avatar Jul 27 '22 15:07 Adamj1232

@jadbox checking back in here. Response has been slow from the Magic team on making the login for available to SDK users. If you would like to create a PR to support this we are very open to it! Otherwise we will await Magic teams updates but there is currently no ETA

Adamj1232 avatar Aug 10 '22 18:08 Adamj1232

Closing this for now but it is on our future/parking lot list

ejc8 avatar Feb 06 '23 19:02 ejc8