fix: validate provider urls before use

Open codefromthecrypt opened this issue 1 year ago • 5 comments

This fixes validation, like #133, except for all providers that accept a hostname/base URL variable.

Oct 13 '24 10:10 codefromthecrypt

@lamchau can you cast eagle eyes over this?

Oct 13 '24 22:10 michaelneale

thanks for the advice @lamchau will revise impl after clarification on https://github.com/block-open-source/goose/pull/147#discussion_r1802101239

Oct 15 '24 22:10 codefromthecrypt

sorry was awol on medical leave. sporadic this week, but will adjust this and others soon

Oct 28 '24 03:10 codefromthecrypt

@codefromthecrypt no worries! hopefully you're doing well/on the mend!

Oct 28 '24 22:10 lamchau

@lamchau PTAL I have consolidated what I could into the same check, and refactored things around it.

Nov 04 '24 07:11 codefromthecrypt

Closing up PRs that point to pre-v1.0 but this is still a good idea, happy to open this up again against v1.0

Feb 17 '25 20:02 baxen